[PATCH] irda: irttp: fix memory leak in irttp_open_tsap() error path

Subsystems: networking [general], the rest

STALE5025d

2 messages, 2 authors, 2012-11-28 · open the first message on its own page

[PATCH] irda: irttp: fix memory leak in irttp_open_tsap() error path

From: Tommi Rantala <hidden>
Date: 2012-11-26 14:16:58

Cleanup the memory we allocated earlier in irttp_open_tsap() when we hit
this error path. The leak goes back to at least 1da177e4
("Linux-2.6.12-rc2").

Discovered with Trinity (the syscall fuzzer).

Signed-off-by: Tommi Rantala <redacted>
---
 net/irda/irttp.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/net/irda/irttp.c b/net/irda/irttp.c
index 1002e33..ae43c62 100644
--- a/net/irda/irttp.c
+++ b/net/irda/irttp.c
@@ -441,6 +441,7 @@ struct tsap_cb *irttp_open_tsap(__u8 stsap_sel, int credit, notify_t *notify)
 	lsap = irlmp_open_lsap(stsap_sel, &ttp_notify, 0);
 	if (lsap == NULL) {
 		IRDA_DEBUG(0, "%s: unable to allocate LSAP!!\n", __func__);
+		__irttp_close_tsap(self);
 		return NULL;
 	}
 
-- 
1.7.9.5

Re: [PATCH] irda: irttp: fix memory leak in irttp_open_tsap() error path

From: David Miller <davem@davemloft.net>
Date: 2012-11-28 16:25:58

From: Tommi Rantala <redacted>
Date: Mon, 26 Nov 2012 16:16:44 +0200
Cleanup the memory we allocated earlier in irttp_open_tsap() when we hit
this error path. The leak goes back to at least 1da177e4
("Linux-2.6.12-rc2").

Discovered with Trinity (the syscall fuzzer).

Signed-off-by: Tommi Rantala <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help