[net-next:master 63/70] net/ipv6/udp_offload.c:29:2: error: implicit declaration of function 'csum_ipv6_magic'

3 messages, 3 authors, 2012-11-16 · open the first message on its own page

[net-next:master 63/70] net/ipv6/udp_offload.c:29:2: error: implicit declaration of function 'csum_ipv6_magic'

From: kbuild test robot <hidden>
Date: 2012-11-16 00:12:24

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   7213dde6c961230d1e4c80fa20df842af573cd9d
commit: 5edbb07dc9474b7d4cd4391a2e6551ad067a0f96 [63/70] ipv6: Separate out UDP offload functionality
config: make ARCH=powerpc chroma_defconfig

All error/warnings:

net/ipv6/udp_offload.c: In function 'udp6_ufo_send_check':
net/ipv6/udp_offload.c:29:2: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

vim +29 +/csum_ipv6_magic net/ipv6/udp_offload.c

5edbb07d Vlad Yasevich 2012-11-15  23  	if (!pskb_may_pull(skb, sizeof(*uh)))
5edbb07d Vlad Yasevich 2012-11-15  24  		return -EINVAL;
5edbb07d Vlad Yasevich 2012-11-15  25  
5edbb07d Vlad Yasevich 2012-11-15  26  	ipv6h = ipv6_hdr(skb);
5edbb07d Vlad Yasevich 2012-11-15  27  	uh = udp_hdr(skb);
5edbb07d Vlad Yasevich 2012-11-15  28  
5edbb07d Vlad Yasevich 2012-11-15 @29  	uh->check = ~csum_ipv6_magic(&ipv6h->saddr, &ipv6h->daddr, skb->len,
5edbb07d Vlad Yasevich 2012-11-15  30  				     IPPROTO_UDP, 0);
5edbb07d Vlad Yasevich 2012-11-15  31  	skb->csum_start = skb_transport_header(skb) - skb->head;
5edbb07d Vlad Yasevich 2012-11-15  32  	skb->csum_offset = offsetof(struct udphdr, check);

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

[PATCH 2/2] ipv6: Fix build error with udp_offload

From: Vlad Yasevich <hidden>
Date: 2012-11-16 02:35:39

Add ip6_checksum.h include.  This should resolve the following issue
that shows up on power:

net/ipv6/udp_offload.c: In function 'udp6_ufo_send_check':
net/ipv6/udp_offload.c:29:2: error: implicit declaration of function
'csum_ipv6_magic' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

Signed-off-by: Vlad Yasevich <redacted>
---
 net/ipv6/udp_offload.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv6/udp_offload.c b/net/ipv6/udp_offload.c
index 8e01c44..0c8934a 100644
--- a/net/ipv6/udp_offload.c
+++ b/net/ipv6/udp_offload.c
@@ -13,6 +13,7 @@
 #include <net/protocol.h>
 #include <net/ipv6.h>
 #include <net/udp.h>
+#include <net/ip6_checksum.h>
 #include "ip6_offload.h"
 
 static int udp6_ufo_send_check(struct sk_buff *skb)
-- 
1.7.7.6

Re: [PATCH 2/2] ipv6: Fix build error with udp_offload

From: David Miller <davem@davemloft.net>
Date: 2012-11-16 03:49:15

From: Vlad Yasevich <redacted>
Date: Thu, 15 Nov 2012 21:35:37 -0500
Add ip6_checksum.h include.  This should resolve the following issue
that shows up on power:

net/ipv6/udp_offload.c: In function 'udp6_ufo_send_check':
net/ipv6/udp_offload.c:29:2: error: implicit declaration of function
'csum_ipv6_magic' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

Signed-off-by: Vlad Yasevich <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help