3 messages, 3 authors, 2012-10-01 · open the first message on its own page
From: David Miller <hidden>
Date: 2012-10-01 21:11:14
From: Daniel Mack <redacted> Date: Wed, 26 Sep 2012 19:24:27 +0200
Allow users to specify the phy interface of the CPSW slaves. The new node parameter is called "phy_if_mode" and is optional. The original behaviour of the driver is preserved when not given. Signed-off-by: Daniel Mack <redacted>
Applied, thanks.
From: Daniel Mack <zonque@gmail.com>
Date: 2012-10-01 21:15:38
On 01.10.2012 23:11, David Miller wrote:
From: Daniel Mack <zonque@gmail.com> Date: Wed, 26 Sep 2012 19:24:27 +0200quoted
Allow users to specify the phy interface of the CPSW slaves. The new node parameter is called "phy_if_mode" and is optional. The original behaviour of the driver is preserved when not given. Signed-off-by: Daniel Mack <zonque@gmail.com>Applied, thanks.
Eh, no - sorry. My original understanding was that a bit in the cpsw registers has to be set only when a certain physical phy mode is in use. Hence we would have needed a way to pass that information in via DT. But as Mugunthan pointed out, that bit must always be set, and the cpsw slaves can stay agnostic to the actual phy mode. So that patch isn't needed. Sorry for the confusion. Daniel
From: David Miller <davem@davemloft.net>
Date: 2012-10-01 21:38:13
From: Daniel Mack <zonque@gmail.com> Date: Mon, 01 Oct 2012 23:15:38 +0200
On 01.10.2012 23:11, David Miller wrote:quoted
From: Daniel Mack <zonque@gmail.com> Date: Wed, 26 Sep 2012 19:24:27 +0200quoted
Allow users to specify the phy interface of the CPSW slaves. The new node parameter is called "phy_if_mode" and is optional. The original behaviour of the driver is preserved when not given. Signed-off-by: Daniel Mack <zonque@gmail.com>Applied, thanks.Eh, no - sorry. My original understanding was that a bit in the cpsw registers has to be set only when a certain physical phy mode is in use. Hence we would have needed a way to pass that information in via DT. But as Mugunthan pointed out, that bit must always be set, and the cpsw slaves can stay agnostic to the actual phy mode. So that patch isn't needed. Sorry for the confusion.
Ok I'll revert.