[PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill

Subsystems: networking [general], the rest, tipc network layer

STALE5066d

2 messages, 2 authors, 2012-11-03 · open the first message on its own page

[PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill

From: Xiaotian Feng <hidden>
Date: 2012-10-31 08:06:06

If tasklet_disable() is called before related tasklet handled,
tasklet_kill will never be finished. tasklet_kill is enough.

Signed-off-by: Xiaotian Feng <redacted>
Cc: Jon Maloy <redacted>
Cc: Allan Stephens <redacted>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: tipc-discussion@lists.sourceforge.net
---
 net/tipc/handler.c |    1 -
 1 file changed, 1 deletion(-)
diff --git a/net/tipc/handler.c b/net/tipc/handler.c
index 111ff83..b36f0fc 100644
--- a/net/tipc/handler.c
+++ b/net/tipc/handler.c
@@ -116,7 +116,6 @@ void tipc_handler_stop(void)
 		return;
 
 	handler_enabled = 0;
-	tasklet_disable(&tipc_tasklet);
 	tasklet_kill(&tipc_tasklet);
 
 	spin_lock_bh(&qitem_lock);
-- 
1.7.9.5

Re: [PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill

From: David Miller <davem@davemloft.net>
Date: 2012-11-03 19:16:00

From: Xiaotian Feng <redacted>
Date: Wed, 31 Oct 2012 16:06:01 +0800
If tasklet_disable() is called before related tasklet handled,
tasklet_kill will never be finished. tasklet_kill is enough.

Signed-off-by: Xiaotian Feng <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help