[PATCH net-next,1/1] hyperv: Remove unnecessary comments in rndis_filter_receive_data()

Subsystems: hyper-v/azure core and drivers, networking drivers, the rest

STALE5105d REVIEWED: 1 (1M)

1 review trailer (1 from subsystem maintainers).

2 messages, 2 authors, 2012-10-22 · open the first message on its own page

[PATCH net-next,1/1] hyperv: Remove unnecessary comments in rndis_filter_receive_data()

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2012-10-18 20:40:37

Checked with Windows networking team, there is only one RNDIS message
in each netvsc packet.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>

---
 drivers/net/hyperv/rndis_filter.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 928148c..7fdeb52 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -363,11 +363,6 @@ static void rndis_filter_receive_data(struct rndis_device *dev,
 
 	rndis_pkt = &msg->msg.pkt;
 
-	/*
-	 * FIXME: Handle multiple rndis pkt msgs that maybe enclosed in this
-	 * netvsc packet (ie TotalDataBufferLength != MessageLength)
-	 */
-
 	/* Remove the rndis header and pass it back up the stack */
 	data_offset = RNDIS_HEADER_SIZE + rndis_pkt->data_offset;
 
-- 
1.7.4.1

Re: [PATCH net-next,1/1] hyperv: Remove unnecessary comments in rndis_filter_receive_data()

From: David Miller <davem@davemloft.net>
Date: 2012-10-22 00:36:05

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Thu, 18 Oct 2012 14:00:52 -0700
Checked with Windows networking team, there is only one RNDIS message
in each netvsc packet.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help