[PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()

Subsystems: networking drivers, qlogic qla3xxx network driver, the rest

STALE5103d

3 messages, 3 authors, 2012-10-31 · open the first message on its own page

[PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()

From: Wei Yongjun <hidden>
Date: 2012-10-26 15:30:33

From: Wei Yongjun <redacted>

The variable retval is initialized but never used
otherwise, so remove the unused variable.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/qlogic/qla3xxx.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 6407d0d..dd4d864a 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -1920,7 +1920,6 @@ static void ql_process_mac_tx_intr(struct ql3_adapter *qdev,
 {
 	struct ql_tx_buf_cb *tx_cb;
 	int i;
-	int retval = 0;
 
 	if (mac_rsp->flags & OB_MAC_IOCB_RSP_S) {
 		netdev_warn(qdev->ndev,
@@ -1935,7 +1934,6 @@ static void ql_process_mac_tx_intr(struct ql3_adapter *qdev,
 			   "Frame too short to be legal, frame not sent\n");
 
 		qdev->ndev->stats.tx_errors++;
-		retval = -EIO;
 		goto frame_not_sent;
 	}
 
@@ -1944,7 +1942,6 @@ static void ql_process_mac_tx_intr(struct ql3_adapter *qdev,
 			   mac_rsp->transaction_id);
 
 		qdev->ndev->stats.tx_errors++;
-		retval = -EIO;
 		goto invalid_seg_count;
 	}
 

RE: [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()

From: Jitendra Kalsaria <hidden>
Date: 2012-10-26 16:35:27

From: Wei Yongjun [mailto:weiyj.lk@gmail.com] 
Sent: Friday, October 26, 2012 8:31 AM
To: Jitendra Kalsaria; Ron Mercer
Cc: yongjun_wei@trendmicro.com.cn; Dept-Eng Linux Driver; netdev
Subject: [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()

From: Wei Yongjun <redacted>

The variable retval is initialized but never used
otherwise, so remove the unused variable.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <redacted>
Acked-by: Jitendra Kalsaria <redacted>

Re: [PATCH -next] qla3xxx: remove unused variable in ql_process_mac_tx_intr()

From: David Miller <davem@davemloft.net>
Date: 2012-10-31 17:36:22

From: Wei Yongjun <redacted>
Date: Fri, 26 Oct 2012 23:30:31 +0800
From: Wei Yongjun <redacted>

The variable retval is initialized but never used
otherwise, so remove the unused variable.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help