Re: [PATCH v1 1/5] cgroup: net_prio: Mark local used function static

2 messages, 2 authors, 2012-10-26 · open the first message on its own page

Re: [PATCH v1 1/5] cgroup: net_prio: Mark local used function static

From: Neil Horman <hidden>
Date: 2012-10-25 18:28:58

On Thu, Oct 25, 2012 at 04:16:55PM +0200, Daniel Wagner wrote:
quoted hunk
From: Daniel Wagner <redacted>

net_prio_attach() is only access via cgroup_subsys callbacks,
therefore we can reduce the visibility of this function.

Signed-off-by: Daniel Wagner <redacted>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: John Fastabend <redacted>
Cc: Li Zefan <redacted>
Cc: Neil Horman <redacted>
Cc: Tejun Heo <redacted>
Cc: <redacted>
Cc: <redacted>
---
 net/core/netprio_cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/netprio_cgroup.c b/net/core/netprio_cgroup.c
index 79285a3..847c02b 100644
--- a/net/core/netprio_cgroup.c
+++ b/net/core/netprio_cgroup.c
@@ -248,7 +248,7 @@ static int update_netprio(const void *v, struct file *file, unsigned n)
 	return 0;
 }
 
-void net_prio_attach(struct cgroup *cgrp, struct cgroup_taskset *tset)
+static void net_prio_attach(struct cgroup *cgrp, struct cgroup_taskset *tset)
 {
 	struct task_struct *p;
 	void *v;
-- 
1.8.0.rc0
Acked-by: Neil Horman <redacted>

Re: [PATCH v1 1/5] cgroup: net_prio: Mark local used function static

From: David Miller <davem@davemloft.net>
Date: 2012-10-26 07:41:48

From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 25 Oct 2012 14:28:58 -0400
On Thu, Oct 25, 2012 at 04:16:55PM +0200, Daniel Wagner wrote:
quoted
From: Daniel Wagner <redacted>

net_prio_attach() is only access via cgroup_subsys callbacks,
therefore we can reduce the visibility of this function.

Signed-off-by: Daniel Wagner <redacted>
 ...
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help