[PATCH] l2tp: session is an array not a pointer

Subsystems: networking [general], the rest

STALE5098d

2 messages, 2 authors, 2012-10-26 · open the first message on its own page

[PATCH] l2tp: session is an array not a pointer

From: Alan Cox <hidden>
Date: 2012-10-25 15:20:25

From: Alan Cox <redacted>

Signed-off-by: Alan Cox <redacted>
---

 net/l2tp/l2tp_netlink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c
index 6c4cc12..bbba3a1 100644
--- a/net/l2tp/l2tp_netlink.c
+++ b/net/l2tp/l2tp_netlink.c
@@ -632,7 +632,7 @@ static int l2tp_nl_session_send(struct sk_buff *skb, u32 portid, u32 seq, int fl
 	     nla_put_u16(skb, L2TP_ATTR_MRU, session->mru)))
 		goto nla_put_failure;
 
-	if ((session->ifname && session->ifname[0] &&
+	if ((session->ifname[0] &&
 	     nla_put_string(skb, L2TP_ATTR_IFNAME, session->ifname)) ||
 	    (session->cookie_len &&
 	     nla_put(skb, L2TP_ATTR_COOKIE, session->cookie_len,

Re: [PATCH] l2tp: session is an array not a pointer

From: David Miller <davem@davemloft.net>
Date: 2012-10-26 07:47:18

From: Alan Cox <redacted>
Date: Thu, 25 Oct 2012 16:22:01 +0100
From: Alan Cox <redacted>

Signed-off-by: Alan Cox <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help