[PATCH net-next] ipv4: tcp: clean up tcp_v4_early_demux()

Subsystems: networking [general], networking [tcp], the rest

STALE5098d

3 messages, 3 authors, 2012-10-23 · open the first message on its own page

[PATCH net-next] ipv4: tcp: clean up tcp_v4_early_demux()

From: Eric Dumazet <hidden>
Date: 2012-10-23 07:42:51

From: Eric Dumazet <redacted>

Use same header helpers than tcp_v6_early_demux() because they
are a bit faster, and as they make IPv4/IPv6 versions look
the same.

Signed-off-by: Eric Dumazet <redacted>
Cc: Neal Cardwell <ncardwell@google.com>
---
 net/ipv4/tcp_ipv4.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index ef998b0..694ea4c 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1918,7 +1918,6 @@ EXPORT_SYMBOL(tcp_v4_do_rcv);
 
 void tcp_v4_early_demux(struct sk_buff *skb)
 {
-	struct net *net = dev_net(skb->dev);
 	const struct iphdr *iph;
 	const struct tcphdr *th;
 	struct sock *sk;
@@ -1926,16 +1925,16 @@ void tcp_v4_early_demux(struct sk_buff *skb)
 	if (skb->pkt_type != PACKET_HOST)
 		return;
 
-	if (!pskb_may_pull(skb, ip_hdrlen(skb) + sizeof(struct tcphdr)))
+	if (!pskb_may_pull(skb, skb_transport_offset(skb) + sizeof(struct tcphdr)))
 		return;
 
 	iph = ip_hdr(skb);
-	th = (struct tcphdr *) ((char *)iph + ip_hdrlen(skb));
+	th = tcp_hdr(skb);
 
 	if (th->doff < sizeof(struct tcphdr) / 4)
 		return;
 
-	sk = __inet_lookup_established(net, &tcp_hashinfo,
+	sk = __inet_lookup_established(dev_net(skb->dev), &tcp_hashinfo,
 				       iph->saddr, th->source,
 				       iph->daddr, ntohs(th->dest),
 				       skb->skb_iif);

Re: [PATCH net-next] ipv4: tcp: clean up tcp_v4_early_demux()

From: Neal Cardwell <ncardwell@google.com>
Date: 2012-10-23 12:59:36

On Tue, Oct 23, 2012 at 3:42 AM, Eric Dumazet [off-list ref] wrote:
From: Eric Dumazet <redacted>

Use same header helpers than tcp_v6_early_demux() because they
are a bit faster, and as they make IPv4/IPv6 versions look
the same.

Signed-off-by: Eric Dumazet <redacted>
Cc: Neal Cardwell <ncardwell@google.com>
---
Acked-by: Neal Cardwell <ncardwell@google.com>

Thanks, Eric!

neal

Re: [PATCH net-next] ipv4: tcp: clean up tcp_v4_early_demux()

From: David Miller <davem@davemloft.net>
Date: 2012-10-23 17:04:09

From: Eric Dumazet <redacted>
Date: Tue, 23 Oct 2012 09:42:47 +0200
From: Eric Dumazet <redacted>

Use same header helpers than tcp_v6_early_demux() because they
are a bit faster, and as they make IPv4/IPv6 versions look
the same.

Signed-off-by: Eric Dumazet <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help