[PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().

Subsystems: networking [general], the rest

STALE5112d

3 messages, 3 authors, 2012-10-22 · open the first message on its own page

[PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().

From: Rami Rosen <hidden>
Date: 2012-10-19 09:10:04

This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().

Signed-off-by: Rami Rosen <redacted>
---
 net/core/dev.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 09cb3f6..b4978e2 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6264,7 +6264,6 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
 		goto out;
 
 	/* Ensure the device has been registrered */
-	err = -EINVAL;
 	if (dev->reg_state != NETREG_REGISTERED)
 		goto out;
 
-- 
1.7.11.4

Re: [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().

From: Serge Hallyn <hidden>
Date: 2012-10-20 00:08:03

Quoting Rami Rosen (ramirose@gmail.com):
This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().

Signed-off-by: Rami Rosen <redacted>
Yup, sure is a duplicate assignment...

Acked-by: Serge E. Hallyn <redacted>
quoted hunk
---
 net/core/dev.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 09cb3f6..b4978e2 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6264,7 +6264,6 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
 		goto out;
 
 	/* Ensure the device has been registrered */
-	err = -EINVAL;
 	if (dev->reg_state != NETREG_REGISTERED)
 		goto out;
 
-- 
1.7.11.4

Re: [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().

From: David Miller <davem@davemloft.net>
Date: 2012-10-22 00:45:11

From: Rami Rosen <redacted>
Date: Fri, 19 Oct 2012 13:09:30 +0200
This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().

Signed-off-by: Rami Rosen <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help