[PATCH] ipv4: fix route mark sparse warning

STALE5108d

2 messages, 2 authors, 2012-10-11 · open the first message on its own page

[PATCH] ipv4: fix route mark sparse warning

From: Stephen Hemminger <hidden>
Date: 2012-10-10 18:28:06

Sparse complains about RTA_MARK which is should be host order according
to include file and usage in iproute.

net/ipv4/route.c:2223:46: warning: incorrect type in argument 3 (different base types)
net/ipv4/route.c:2223:46:    expected restricted __be32 [usertype] value
net/ipv4/route.c:2223:46:    got unsigned int [unsigned] [usertype] flowic_mark

Signed-off-by: Stephen Hemminger <redacted>

--- a/net/ipv4/route.c	2012-10-09 10:35:03.323140263 -0700
+++ b/net/ipv4/route.c	2012-10-10 10:59:08.774798362 -0700
@@ -2220,7 +2220,7 @@ static int rt_fill_info(struct net *net,
 		goto nla_put_failure;
 
 	if (fl4->flowi4_mark &&
-	    nla_put_be32(skb, RTA_MARK, fl4->flowi4_mark))
+	    nla_put_u32(skb, RTA_MARK, fl4->flowi4_mark))
 		goto nla_put_failure;
 
 	error = rt->dst.error;

Re: [PATCH] ipv4: fix route mark sparse warning

From: David Miller <davem@davemloft.net>
Date: 2012-10-11 02:55:21

From: Stephen Hemminger <redacted>
Date: Wed, 10 Oct 2012 11:27:25 -0700
Sparse complains about RTA_MARK which is should be host order according
to include file and usage in iproute.

net/ipv4/route.c:2223:46: warning: incorrect type in argument 3 (different base types)
net/ipv4/route.c:2223:46:    expected restricted __be32 [usertype] value
net/ipv4/route.c:2223:46:    got unsigned int [unsigned] [usertype] flowic_mark

Signed-off-by: Stephen Hemminger <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help