Remove noisy printks from llcp_sock_connect

Subsystems: networking [general], nfc subsystem, the rest

2 messages, 2 authors, 2012-10-04 · open the first message on its own page

Remove noisy printks from llcp_sock_connect

From: Dave Jones <hidden>
Date: 2012-10-04 19:51:25

Validation of userspace input shouldn't trigger dmesg spamming.

Signed-off-by: Dave Jones <redacted>
diff --git a/net/nfc/llcp/sock.c b/net/nfc/llcp/sock.c
index 40f056d..63e4cdc 100644
--- a/net/nfc/llcp/sock.c
+++ b/net/nfc/llcp/sock.c
@@ -497,15 +497,11 @@ static int llcp_sock_connect(struct socket *sock, struct sockaddr *_addr,
 	pr_debug("sock %p sk %p flags 0x%x\n", sock, sk, flags);
 
 	if (!addr || len < sizeof(struct sockaddr_nfc) ||
-	    addr->sa_family != AF_NFC) {
-		pr_err("Invalid socket\n");
+	    addr->sa_family != AF_NFC)
 		return -EINVAL;
-	}
 
-	if (addr->service_name_len == 0 && addr->dsap == 0) {
-		pr_err("Missing service name or dsap\n");
+	if (addr->service_name_len == 0 && addr->dsap == 0)
 		return -EINVAL;
-	}
 
 	pr_debug("addr dev_idx=%u target_idx=%u protocol=%u\n", addr->dev_idx,
 		 addr->target_idx, addr->nfc_protocol);

Re: Remove noisy printks from llcp_sock_connect

From: David Miller <davem@davemloft.net>
Date: 2012-10-04 19:59:04

From: Dave Jones <redacted>
Date: Thu, 4 Oct 2012 15:51:11 -0400
Validation of userspace input shouldn't trigger dmesg spamming.

Signed-off-by: Dave Jones <redacted>
Applied, thanks Dave.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help