# Re: Davicom DM9000C driver

- From: Bruno Prémont \<bonbons@linux-vserver.org\>
- Date: 2012-09-19 16:40:42 
- List: netdev
- Page: https://ratatoskr.run/netdev/2012/09/3925779

```text
Hi Allen,

[CCing netdev, keeping .c/.h source attached]

On Wed, 19 September 2012 Allen Huang (黃偉格)  [ref] wrote:
> I'm Allen Huang from Davicom. We are hereby opensourcing the linux
> driver for our DM9000C. 

Ah, from looking at the code DM9000C looks like it is some nerwork chip,
what platforms does it show up on?

> We would appreciate any comments that you have on our driver and
> whether it is ready to go into the kernel. Please see DM9000C driver in the
> attachment.

It would be nice if you could include the changes to Kconfig/Makefile
including a description as it's not clear on what kind of devices the
chip can be encountered.

Also please properly tag the source files attachments as text/plain.


With a quick glance at the code:
- your comments are often single-line C++ style //
  and should be changed to /*  */.

- comments that look like author/revision tags

- there are blocks of code commented or inside if (1) {}

- some printk calls missing KERN_ severity tag

- indentation issues


Please fix above issues (and have a look at scripts/checkpatch.pl) and
respin (as a patch) taking care to CC netdev so network people have to
chance to see it.

Bruno
```

## Attachments

- [dm9000\_KT2.6.31.c](https://ratatoskr.run/netdev/2012/09/3925779/attachment/0) (text/plain, 37105 bytes)
- [dm9000\_KT2.6.31.h](https://ratatoskr.run/netdev/2012/09/3925779/attachment/1) (text/plain, 4180 bytes)