Endianess bug fix for sierra_net

Subsystems: networking drivers, the rest, usb networking drivers

2 messages, 2 authors, 2012-09-10 · open the first message on its own page

Endianess bug fix for sierra_net

From: Lennart Sorensen <hidden>
Date: 2012-09-07 22:21:10

I discovered I couldn't get sierra_net to work on a powerpc.  Turns out
the firmware attribute check assumes the system is little endian and
hence fails because the attributes is a 16 bit value.

Signed-off-by: Len Sorensen <redacted>
diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c
index 7be49ea..8e22417 100644
--- a/drivers/net/usb/sierra_net.c
+++ b/drivers/net/usb/sierra_net.c
@@ -656,7 +656,7 @@ static int sierra_net_get_fw_attr(struct usbnet *dev, u16 *datap)
 		return -EIO;
 	}
 
-	*datap = *attrdata;
+	*datap = le16_to_cpu(*attrdata);
 
 	kfree(attrdata);
 	return result;

Re: Endianess bug fix for sierra_net

From: David Miller <davem@davemloft.net>
Date: 2012-09-10 19:06:17

From: "Lennart Sorensen" <redacted>
Date: Fri, 7 Sep 2012 18:14:02 -0400
I discovered I couldn't get sierra_net to work on a powerpc.  Turns out
the firmware attribute check assumes the system is little endian and
hence fails because the attributes is a 16 bit value.

Signed-off-by: Len Sorensen <redacted>
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help