[PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h

Subsystems: ethernet phy library, networking drivers, the rest

STALE5110d

3 messages, 3 authors, 2012-09-07 · open the first message on its own page

[PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h

From: Timur Tabi <hidden>
Date: 2012-09-07 21:31:11

mdio-mux-mmioreg.c uses function of_address_to_resource(), which is defined
in linux/of_address.h.  This fixes a compilation error:

drivers/net/phy/mdio-mux-mmioreg.c: In function 'mdio_mux_mmioreg_probe':
drivers/net/phy/mdio-mux-mmioreg.c:83:2: error: implicit declaration of
	function 'of_address_to_resource'

Reported-by: Randy Dunlap <redacted>
Signed-off-by: Timur Tabi <redacted>

---
 drivers/net/phy/mdio-mux-mmioreg.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/mdio-mux-mmioreg.c b/drivers/net/phy/mdio-mux-mmioreg.c
index 098239a..9061ba6 100644
--- a/drivers/net/phy/mdio-mux-mmioreg.c
+++ b/drivers/net/phy/mdio-mux-mmioreg.c
@@ -12,6 +12,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/device.h>
+#include <linux/of_address.h>
 #include <linux/of_mdio.h>
 #include <linux/module.h>
 #include <linux/init.h>
-- 
1.7.3.4

Re: [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h

From: David Miller <davem@davemloft.net>
Date: 2012-09-07 21:33:01

From: Timur Tabi <redacted>
Date: Fri, 7 Sep 2012 16:30:57 -0500
mdio-mux-mmioreg.c uses function of_address_to_resource(), which is defined
in linux/of_address.h.  This fixes a compilation error:

drivers/net/phy/mdio-mux-mmioreg.c: In function 'mdio_mux_mmioreg_probe':
drivers/net/phy/mdio-mux-mmioreg.c:83:2: error: implicit declaration of
	function 'of_address_to_resource'

Reported-by: Randy Dunlap <redacted>
Signed-off-by: Timur Tabi <redacted>
Applied, thanks.

Re: [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h

From: Randy Dunlap <hidden>
Date: 2012-09-07 23:42:53

On 09/07/2012 02:30 PM, Timur Tabi wrote:
mdio-mux-mmioreg.c uses function of_address_to_resource(), which is defined
in linux/of_address.h.  This fixes a compilation error:

drivers/net/phy/mdio-mux-mmioreg.c: In function 'mdio_mux_mmioreg_probe':
drivers/net/phy/mdio-mux-mmioreg.c:83:2: error: implicit declaration of
	function 'of_address_to_resource'

Reported-by: Randy Dunlap <redacted>
Signed-off-by: Timur Tabi <redacted>

Acked-by: Randy Dunlap <redacted>

Thanks.
quoted hunk
---
 drivers/net/phy/mdio-mux-mmioreg.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/mdio-mux-mmioreg.c b/drivers/net/phy/mdio-mux-mmioreg.c
index 098239a..9061ba6 100644
--- a/drivers/net/phy/mdio-mux-mmioreg.c
+++ b/drivers/net/phy/mdio-mux-mmioreg.c
@@ -12,6 +12,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/device.h>
+#include <linux/of_address.h>
 #include <linux/of_mdio.h>
 #include <linux/module.h>
 #include <linux/init.h>


-- 
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help