[PATCH] net/irda: sh_sir: fix return value check in sh_sir_set_baudrate()

Subsystems: networking drivers, the rest

STALE5078d

2 messages, 2 authors, 2012-09-21 · open the first message on its own page

[PATCH] net/irda: sh_sir: fix return value check in sh_sir_set_baudrate()

From: Wei Yongjun <hidden>
Date: 2012-09-21 07:13:55

From: Wei Yongjun <redacted>

In case of error, the function clk_get() returns ERR_PTR()
and never returns NULL pointer. The NULL test in the error
handling should be replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/irda/sh_sir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index 256eddf..7951094 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -280,7 +280,7 @@ static int sh_sir_set_baudrate(struct sh_sir_self *self, u32 baudrate)
 	}
 
 	clk = clk_get(NULL, "irda_clk");
-	if (!clk) {
+	if (IS_ERR(clk)) {
 		dev_err(dev, "can not get irda_clk\n");
 		return -EIO;
 	}

Re: [PATCH] net/irda: sh_sir: fix return value check in sh_sir_set_baudrate()

From: David Miller <davem@davemloft.net>
Date: 2012-09-21 17:47:44

From: Wei Yongjun <redacted>
Date: Fri, 21 Sep 2012 15:13:55 +0800
From: Wei Yongjun <redacted>

In case of error, the function clk_get() returns ERR_PTR()
and never returns NULL pointer. The NULL test in the error
handling should be replaced with IS_ERR().

dpatch engine is used to auto generated this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help