# RE: \[PATCH net-next\] mlx4: use dev\_kfree\_skb() instead of dev\_kfree\_skb\_any()

- From: Yevgeny Petrilin \<hidden\>
- Date: 2012-09-19 07:59:36 
- List: netdev
- Page: https://ratatoskr.run/netdev/2012/09/10904305
- Thread: https://ratatoskr.run/netdev/2012/09/10904103/t.md

```text
> 
> Since commit e22979d96a5 (mlx4_en: Moving to Interrupts for TX
> completions), we no longer can free TX skb from hard IRQ, but only from
> normal softirq or process context.
> 
> Therefore, we can directly call dev_kfree_skb() from
> mlx4_en_free_tx_desc() like other conventional NAPI drivers.
> 

Hi Eric,
At the moment the TX completion processing is done from IRQ context.
So I think we need to change the driver to work with NAPI for TX completions
before making this change.

I'll send the patch in a few days.

Yevgeny
```
