Re: [PATCH v3 7/8] cgroup: Assign subsystem IDs during compile time

On Tue, Sep 11, 2012 at 02:01:09PM -0700, Tejun Heo wrote:

For example, it's not evident the above is correct and it's burried
with all other changes.  Can't we just assign the fixed subsys ID to
net_prio_subsys_id in this patch?  This patch would be correct without
any netprio changes, no?

Oops, that was wrong.  net_prio_subsys_id itself becomes constant.
Let's please better explain why the RCU trick removal is safe then.

Thanks.

-- 
tejun

On 09/11/2012 11:08 PM, Tejun Heo wrote:

On Tue, Sep 11, 2012 at 02:01:09PM -0700, Tejun Heo wrote:

quoted

For example, it's not evident the above is correct and it's burried
with all other changes.  Can't we just assign the fixed subsys ID to
net_prio_subsys_id in this patch?  This patch would be correct without
any netprio changes, no?

Oops, that was wrong.  net_prio_subsys_id itself becomes constant.
Let's please better explain why the RCU trick removal is safe then.

In the last paragraph in the commit message I tried to document why it 
is safe to remove the RCU trick. Not good enough?