[PATCH] caif: move the dereference below the NULL test

Subsystems: networking [general], the rest

STALE5079d

2 messages, 2 authors, 2012-09-10 · open the first message on its own page

[PATCH] caif: move the dereference below the NULL test

From: Wei Yongjun <hidden>
Date: 2012-09-10 04:38:28

From: Wei Yongjun <redacted>

The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <redacted>
---
 net/caif/cfsrvl.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/caif/cfsrvl.c b/net/caif/cfsrvl.c
index dd485f6..ba217e9 100644
--- a/net/caif/cfsrvl.c
+++ b/net/caif/cfsrvl.c
@@ -211,9 +211,10 @@ void caif_client_register_refcnt(struct cflayer *adapt_layer,
 					void (*put)(struct cflayer *lyr))
 {
 	struct cfsrvl *service;
-	service = container_of(adapt_layer->dn, struct cfsrvl, layer);
 
-	WARN_ON(adapt_layer == NULL || adapt_layer->dn == NULL);
+	if (WARN_ON(adapt_layer == NULL || adapt_layer->dn == NULL))
+		return;
+	service = container_of(adapt_layer->dn, struct cfsrvl, layer);
 	service->hold = hold;
 	service->put = put;
 }

Re: [PATCH] caif: move the dereference below the NULL test

From: David Miller <davem@davemloft.net>
Date: 2012-09-10 20:14:11

From: Wei Yongjun <redacted>
Date: Mon, 10 Sep 2012 12:38:27 +0800
From: Wei Yongjun <redacted>

The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help