|PATCH] seeq: Add missing spinlock init

2 messages, 2 authors, 2012-09-07 · open the first message on its own page

|PATCH] seeq: Add missing spinlock init

From: Jean Delvare <hidden>
Date: 2012-09-06 10:47:15

It doesn't seem this spinlock was properly initialized.

Signed-off-by: Jean Delvare <redacted>
---
I can't even build-test this.

 drivers/net/ethernet/seeq/sgiseeq.c |    1 +
 1 file changed, 1 insertion(+)
--- linux-3.6-rc4.orig/drivers/net/ethernet/seeq/sgiseeq.c	2012-07-21 22:58:29.000000000 +0200
+++ linux-3.6-rc4/drivers/net/ethernet/seeq/sgiseeq.c	2012-09-06 12:40:30.092144722 +0200
@@ -751,6 +751,7 @@ static int __devinit sgiseeq_probe(struc
 	sp->srings = sr;
 	sp->rx_desc = sp->srings->rxvector;
 	sp->tx_desc = sp->srings->txvector;
+	spin_lock_init(&sp->tx_lock);
 
 	/* A couple calculations now, saves many cycles later. */
 	setup_rx_ring(dev, sp->rx_desc, SEEQ_RX_BUFFERS);

-- 
Jean Delvare

Re: |PATCH] seeq: Add missing spinlock init

From: David Miller <davem@davemloft.net>
Date: 2012-09-07 16:59:53

From: Jean Delvare <redacted>
Date: Thu, 6 Sep 2012 12:47:05 +0200
It doesn't seem this spinlock was properly initialized.

Signed-off-by: Jean Delvare <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help