[PATCH] mac80211: use list_move instead of list_del/list_add

Subsystems: mac80211, the rest

STALE5089d

2 messages, 2 authors, 2012-09-06 · open the first message on its own page

[PATCH] mac80211: use list_move instead of list_del/list_add

From: Wei Yongjun <hidden>
Date: 2012-09-06 05:20:54

From: Wei Yongjun <redacted>

Using list_move() instead of list_del() + list_add().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <redacted>
---
 net/mac80211/offchannel.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c
index 635c325..7fbf99d 100644
--- a/net/mac80211/offchannel.c
+++ b/net/mac80211/offchannel.c
@@ -227,8 +227,7 @@ static void ieee80211_hw_roc_start(struct work_struct *work)
 			u32 dur = dep->duration;
 			dep->duration = dur - roc->duration;
 			roc->duration = dur;
-			list_del(&dep->list);
-			list_add(&dep->list, &roc->list);
+			list_move(&dep->list, &roc->list);
 		}
 	}
  out_unlock:

Re: [PATCH] mac80211: use list_move instead of list_del/list_add

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2012-09-06 09:55:51

On Thu, 2012-09-06 at 13:20 +0800, Wei Yongjun wrote:
From: Wei Yongjun <redacted>

Using list_move() instead of list_del() + list_add().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <redacted>
Applied. FWIW, I don't think it's really a "problem" rather than a
simplification or something like that, but anyway.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help