[PATCH] bnx2x: use list_move_tail instead of list_del/list_add_tail

Subsystems: broadcom bnx2x 10 gigabit ethernet driver, networking drivers, the rest

STALE5083d

2 messages, 2 authors, 2012-09-05 · open the first message on its own page

[PATCH] bnx2x: use list_move_tail instead of list_del/list_add_tail

From: Wei Yongjun <hidden>
Date: 2012-09-05 07:06:56

From: Wei Yongjun <redacted>

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 62f754b..5a5fbf5 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -229,8 +229,7 @@ static inline int bnx2x_exe_queue_step(struct bnx2x *bp,
 			 */
 			list_add_tail(&spacer.link, &o->pending_comp);
 			mb();
-			list_del(&elem->link);
-			list_add_tail(&elem->link, &o->pending_comp);
+			list_move_tail(&elem->link, &o->pending_comp);
 			list_del(&spacer.link);
 		} else
 			break;

Re: [PATCH] bnx2x: use list_move_tail instead of list_del/list_add_tail

From: David Miller <davem@davemloft.net>
Date: 2012-09-05 21:50:32

From: Wei Yongjun <redacted>
Date: Wed, 5 Sep 2012 15:06:55 +0800
From: Wei Yongjun <redacted>

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help