[PATCH 00/11] recently added ARM defconfig warnings

STALE5100d

4 messages, 3 authors, 2012-08-08 · open the first message on its own page

[PATCH 00/11] recently added ARM defconfig warnings

From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-08-08 14:47:17

These patches address problems that showed up in new warnings
when building all ARM defconfig files in v3.6-rc1 compared
with v3.5.

I can merge them through the arm-soc tree or have subsystem
maintainers pick them up if they prefer.

Arnd Bergmann (11):
  ARM: topology: mark init_cpu_topology as __init
  mfd/asic3: fix asic3_mfd_probe return value
  usb/ohci-omap: remove unused variable
  ARM: ux500: really kill snowball_of_platform_devs
  ARM: exynos: exynos_pm_add_dev_to_genpd may be unused
  gpio: em: do not discard em_gio_irq_domain_cleanup
  net/stmmac: mark probe function as __devinit
  mtd/omap2: fix dmaengine_slave_config error handling
  regulator/twl: remove fixed resource handling
  spi/s3c64xx: improve error handling
  pm/drivers: fix use of SIMPLE_DEV_PM_OPS

Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <redacted>
Cc: Grant Likely <redacted>
Cc: Grazvydas Ignotas <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jaswinder Singh <redacted>
Cc: Kukjin Kim <redacted>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Lee Jones <redacted>
Cc: Linus Walleij <redacted>
Cc: Magnus Damm <redacted>
Cc: Mark Brown <redacted>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Parsons <redacted>
Cc: Peter Zijlstra <redacted>
Cc: Philipp Zabel <redacted>
Cc: Rafael J. Wysocki <redacted>
Cc: Richard Zhao <redacted>
Cc: Russell King <redacted>
Cc: Samuel Ortiz <redacted>
Cc: Stefan Roese <sr@denx.de>
Cc: Takashi Iwai <redacted>
Cc: Thomas Abraham <redacted>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: netdev@vger.kernel.org

 arch/arm/kernel/topology.c                         |    2 +-
 arch/arm/mach-exynos/pm_domains.c                  |    2 +-
 arch/arm/mach-ux500/board-mop500.c                 |    5 -----
 drivers/char/hw_random/omap-rng.c                  |    2 +-
 drivers/gpio/gpio-em.c                             |    2 +-
 drivers/i2c/busses/i2c-tegra.c                     |    2 +-
 drivers/mfd/asic3.c                                |    1 +
 drivers/mtd/nand/omap2.c                           |    7 +++----
 .../net/ethernet/stmicro/stmmac/stmmac_platform.c  |    2 +-
 drivers/regulator/twl-regulator.c                  |   21 --------------------
 drivers/spi/spi-s3c64xx.c                          |    2 +-
 drivers/usb/host/ohci-omap.c                       |    2 --
 sound/drivers/dummy.c                              |    2 +-
 13 files changed, 12 insertions(+), 40 deletions(-)

-- 
1.7.10

[PATCH 07/11] net/stmmac: mark probe function as __devinit

From: Arnd Bergmann <arnd@arndb.de>
Date: 2012-08-08 14:47:42

Driver probe functions are generally __devinit so they will be
discarded after initialization for non-hotplug kernels.
This was found by a new warning after patch 6a228452d "stmmac: Add
device-tree support" adds a new __devinit function that is called
from stmmac_pltfr_probe.

Without this patch, building socfpga_defconfig results in:

WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt()
The function stmmac_pltfr_probe() references
the function __devinit stmmac_probe_config_dt().
This is often because stmmac_pltfr_probe lacks a __devinit
annotation or the annotation of stmmac_probe_config_dt is wrong.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Stefan Roese <sr@denx.de>
Cc: Giuseppe Cavallaro <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index cd01ee7..b93245c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -74,7 +74,7 @@ static int __devinit stmmac_probe_config_dt(struct platform_device *pdev,
  * the necessary resources and invokes the main to init
  * the net device, register the mdio bus etc.
  */
-static int stmmac_pltfr_probe(struct platform_device *pdev)
+static int __devinit stmmac_pltfr_probe(struct platform_device *pdev)
 {
 	int ret = 0;
 	struct resource *res;
-- 
1.7.10

Re: [PATCH 07/11] net/stmmac: mark probe function as __devinit

From: Stefan Roese <sr@denx.de>
Date: 2012-08-08 15:07:33

On 08/08/2012 04:47 PM, Arnd Bergmann wrote:
Driver probe functions are generally __devinit so they will be
discarded after initialization for non-hotplug kernels.
This was found by a new warning after patch 6a228452d "stmmac: Add
device-tree support" adds a new __devinit function that is called
from stmmac_pltfr_probe.

Without this patch, building socfpga_defconfig results in:

WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt()
The function stmmac_pltfr_probe() references
the function __devinit stmmac_probe_config_dt().
This is often because stmmac_pltfr_probe lacks a __devinit
annotation or the annotation of stmmac_probe_config_dt is wrong.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Stefan Roese <sr@denx.de>
Cc: Giuseppe Cavallaro <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

Re: [PATCH 07/11] net/stmmac: mark probe function as __devinit

From: David Miller <davem@davemloft.net>
Date: 2012-08-08 23:08:55

From: Arnd Bergmann <arnd@arndb.de>
Date: Wed,  8 Aug 2012 16:47:24 +0200
Driver probe functions are generally __devinit so they will be
discarded after initialization for non-hotplug kernels.
This was found by a new warning after patch 6a228452d "stmmac: Add
device-tree support" adds a new __devinit function that is called
from stmmac_pltfr_probe.

Without this patch, building socfpga_defconfig results in:

WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt()
The function stmmac_pltfr_probe() references
the function __devinit stmmac_probe_config_dt().
This is often because stmmac_pltfr_probe lacks a __devinit
annotation or the annotation of stmmac_probe_config_dt is wrong.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Stefan Roese <sr@denx.de>
Cc: Giuseppe Cavallaro <redacted>
Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help