[PATCH 2/5] net:atm:fix up ENOIOCTLCMD error handling

Subsystems: atm, networking [general], the rest

STALE5071d

2 messages, 2 authors, 2012-08-31 · open the first message on its own page

[PATCH 2/5] net:atm:fix up ENOIOCTLCMD error handling

From: Wanlong Gao <hidden>
Date: 2012-08-27 07:25:32

At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Wanlong Gao <redacted>
---
 net/atm/resources.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/atm/resources.c b/net/atm/resources.c
index 23f45ce..0447d5d 100644
--- a/net/atm/resources.c
+++ b/net/atm/resources.c
@@ -432,7 +432,7 @@ int atm_dev_ioctl(unsigned int cmd, void __user *arg, int compat)
 			size = dev->ops->ioctl(dev, cmd, buf);
 		}
 		if (size < 0) {
-			error = (size == -ENOIOCTLCMD ? -EINVAL : size);
+			error = (size == -ENOIOCTLCMD ? -ENOTTY : size);
 			goto done;
 		}
 	}
-- 
1.7.12

Re: [PATCH 2/5] net:atm:fix up ENOIOCTLCMD error handling

From: David Miller <davem@davemloft.net>
Date: 2012-08-31 20:14:47

From: Wanlong Gao <redacted>
Date: Mon, 27 Aug 2012 15:23:13 +0800
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Wanlong Gao <redacted>
Applied to net-next, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help