[PATCH 2/2] drivers/net/ethernet/tundra/tsi108_eth.c: delete double assignment

Subsystems: networking drivers, the rest

STALE5117d

2 messages, 2 authors, 2012-08-30 · open the first message on its own page

[PATCH 2/2] drivers/net/ethernet/tundra/tsi108_eth.c: delete double assignment

From: Julia Lawall <hidden>
Date: 2012-08-26 08:18:50

From: Julia Lawall <redacted>

Delete successive assignments to the same location.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression i;
@@

*i = ...;
 i = ...;
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 drivers/net/ethernet/tundra/tsi108_eth.c |    1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/tundra/tsi108_eth.c b/drivers/net/ethernet/tundra/tsi108_eth.c
index 277c93e..8fa947a 100644
--- a/drivers/net/ethernet/tundra/tsi108_eth.c
+++ b/drivers/net/ethernet/tundra/tsi108_eth.c
@@ -1359,7 +1359,6 @@ static int tsi108_open(struct net_device *dev)
 		}
 
 		data->rxskbs[i] = skb;
-		data->rxskbs[i] = skb;
 		data->rxring[i].buf0 = virt_to_phys(data->rxskbs[i]->data);
 		data->rxring[i].misc = TSI108_RX_OWN | TSI108_RX_INT;
 	}

Re: [PATCH 2/2] drivers/net/ethernet/tundra/tsi108_eth.c: delete double assignment

From: David Miller <davem@davemloft.net>
Date: 2012-08-30 17:09:14

From: Julia Lawall <redacted>
Date: Sun, 26 Aug 2012 10:18:35 +0200
From: Julia Lawall <redacted>

Delete successive assignments to the same location.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
 ...
Signed-off-by: Julia Lawall <redacted>
Applied to net-next, thanks Julia.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help