From: Eric W. Biederman <hidden> Date: 2012-08-07 17:17:25
Since I am motivated to get things done, and since there has been much
grumbling about my patches not implementing tunables, I have added
tunable support on top of my last patchset.
I have performed basic testing on the these patches and nothing
appears amis.
The sm statemachine is a major tease as it has all of these association
and endpoint pointers in the common set of function parameters that turn
out to be NULL at the most inconvinient times. So I added to the common
parameter list a struct net pointer, that is never NULL.
include/net/netns/sctp.h | 96 +++++++-
include/net/sctp/sctp.h | 16 +-
include/net/sctp/sm.h | 8 +-
include/net/sctp/structs.h | 126 +---------
net/sctp/associola.c | 18 +-
net/sctp/auth.c | 20 ++-
net/sctp/bind_addr.c | 6 +-
net/sctp/endpointola.c | 13 +-
net/sctp/input.c | 6 +-
net/sctp/primitive.c | 4 +-
net/sctp/protocol.c | 137 +++++-----
net/sctp/sm_make_chunk.c | 61 +++--
net/sctp/sm_sideeffect.c | 26 ++-
net/sctp/sm_statefuns.c | 631 ++++++++++++++++++++++++--------------------
net/sctp/sm_statetable.c | 17 +-
net/sctp/socket.c | 92 ++++---
net/sctp/sysctl.c | 200 ++++++++------
net/sctp/transport.c | 23 +-
18 files changed, 817 insertions(+), 683 deletions(-)
Eric W. Biederman (7):
sctp: Add infrastructure for per net sysctls
sctp: Push struct net down to sctp_chunk_event_lookup
sctp: Push struct net down into sctp_transport_init
sctp: Push struct net down into sctp_in_scope
sctp: Push struct net down into all of the state machine functions
sctp: Push struct net down into sctp_verify_ext_param
sctp: Making sysctl tunables per net
Eric
From: David Miller <davem@davemloft.net> Date: 2012-08-09 06:21:03
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Tue, 07 Aug 2012 10:17:02 -0700
Since I am motivated to get things done, and since there has been much
grumbling about my patches not implementing tunables, I have added
tunable support on top of my last patchset.
I have performed basic testing on the these patches and nothing
appears amis.
The sm statemachine is a major tease as it has all of these association
and endpoint pointers in the common set of function parameters that turn
out to be NULL at the most inconvinient times. So I added to the common
parameter list a struct net pointer, that is never NULL.
I like Eric's patch set and I'd like to apply it to net-next.
Vlad?
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Tue, 07 Aug 2012 10:17:02 -0700
quoted
Since I am motivated to get things done, and since there has been much
grumbling about my patches not implementing tunables, I have added
tunable support on top of my last patchset.
I have performed basic testing on the these patches and nothing
appears amis.
The sm statemachine is a major tease as it has all of these association
and endpoint pointers in the common set of function parameters that turn
out to be NULL at the most inconvinient times. So I added to the common
parameter list a struct net pointer, that is never NULL.
I like Eric's patch set and I'd like to apply it to net-next.
Vlad?
I like these patches much more as well, but not done reviewing yet.
I'll try to finish the review tonight
-vlad
From: David Miller <davem@davemloft.net> Date: 2012-08-14 21:14:18
Come on Vlad, please review this stuff some time this century. If you
want inclusion to be dependent upon your review, then the onus is on
you to review it in a timely manner. And you are not doing so here.
I'm not letting Eric's patches rot in patchwork for more than a week,
this is completely unacceptable.
Come on Vlad, please review this stuff some time this century. If you
want inclusion to be dependent upon your review, then the onus is on
you to review it in a timely manner. And you are not doing so here.
I'm not letting Eric's patches rot in patchwork for more than a week,
this is completely unacceptable.
I swear I sent an ACK 2 days ago, but I now see it sitting in my draft
folder. My bad. I'll go now and dust off the ACK...
-vlad
Since I am motivated to get things done, and since there has been much
grumbling about my patches not implementing tunables, I have added
tunable support on top of my last patchset.
I have performed basic testing on the these patches and nothing
appears amis.
The sm statemachine is a major tease as it has all of these association
and endpoint pointers in the common set of function parameters that turn
out to be NULL at the most inconvinient times. So I added to the common
parameter list a struct net pointer, that is never NULL.
include/net/netns/sctp.h | 96 +++++++-
include/net/sctp/sctp.h | 16 +-
include/net/sctp/sm.h | 8 +-
include/net/sctp/structs.h | 126 +---------
net/sctp/associola.c | 18 +-
net/sctp/auth.c | 20 ++-
net/sctp/bind_addr.c | 6 +-
net/sctp/endpointola.c | 13 +-
net/sctp/input.c | 6 +-
net/sctp/primitive.c | 4 +-
net/sctp/protocol.c | 137 +++++-----
net/sctp/sm_make_chunk.c | 61 +++--
net/sctp/sm_sideeffect.c | 26 ++-
net/sctp/sm_statefuns.c | 631 ++++++++++++++++++++++++--------------------
net/sctp/sm_statetable.c | 17 +-
net/sctp/socket.c | 92 ++++---
net/sctp/sysctl.c | 200 ++++++++------
net/sctp/transport.c | 23 +-
18 files changed, 817 insertions(+), 683 deletions(-)
Eric W. Biederman (7):
sctp: Add infrastructure for per net sysctls
sctp: Push struct net down to sctp_chunk_event_lookup
sctp: Push struct net down into sctp_transport_init
sctp: Push struct net down into sctp_in_scope
sctp: Push struct net down into all of the state machine functions
sctp: Push struct net down into sctp_verify_ext_param
sctp: Making sysctl tunables per net
Eric
Acked-by: Vlad Yasevich <redacted>
To this entire follow-on series. This is much better.
From: David Miller <davem@davemloft.net> Date: 2012-08-15 06:10:47
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Tue, 07 Aug 2012 10:17:02 -0700
Since I am motivated to get things done, and since there has been much
grumbling about my patches not implementing tunables, I have added
tunable support on top of my last patchset.
I have performed basic testing on the these patches and nothing
appears amis.
The sm statemachine is a major tease as it has all of these association
and endpoint pointers in the common set of function parameters that turn
out to be NULL at the most inconvinient times. So I added to the common
parameter list a struct net pointer, that is never NULL.
Now that I have the ACKs from Vlad, I'm applying all of your work,
thanks Eric.