[PATCH] tcp_output: fix sparse warning for tcp_wfree

Subsystems: networking [general], networking [tcp], the rest

STALE5110d

2 messages, 2 authors, 2012-08-06 · open the first message on its own page

[PATCH] tcp_output: fix sparse warning for tcp_wfree

From: Silviu-Mihai Popescu <hidden>
Date: 2012-08-04 19:31:35

Fix sparse warning:
	* symbol 'tcp_wfree' was not declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <redacted>
---
 net/ipv4/tcp_output.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 3f1bcff..18475e0 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -940,7 +940,7 @@ void __init tcp_tasklet_init(void)
  * We cant xmit new skbs from this context, as we might already
  * hold qdisc lock.
  */
-void tcp_wfree(struct sk_buff *skb)
+static void tcp_wfree(struct sk_buff *skb)
 {
 	struct sock *sk = skb->sk;
 	struct tcp_sock *tp = tcp_sk(sk);
-- 
1.7.9.5

Re: [PATCH] tcp_output: fix sparse warning for tcp_wfree

From: David Miller <davem@davemloft.net>
Date: 2012-08-06 20:30:11

From: Silviu-Mihai Popescu <redacted>
Date: Sat,  4 Aug 2012 22:31:29 +0300
Fix sparse warning:
	* symbol 'tcp_wfree' was not declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help