Re: [PATCH] cxgb3: remove pointless conditional before kfree_skb()

On 08/28/2012 09:24 PM, David Laight wrote:

quoted

-	if (t->nofail_skb)
-		kfree_skb(t->nofail_skb);
+	kfree_skb(t->nofail_skb);

Some of these conditionals might be there for performance
reasons - eg if common path and normally NULL.

I have a quick look at those code, cxgb3_offload_deactivate()
is only used when remove device or device error and then disable
the device, so maybe it is not a common path.