[PATCH] ixgbe: using is_zero_ether_addr() to simplify the code

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE5091d

2 messages, 2 authors, 2012-08-26 · open the first message on its own page

[PATCH] ixgbe: using is_zero_ether_addr() to simplify the code

From: Wei Yongjun <hidden>
Date: 2012-08-26 00:53:42

From: Wei Yongjun <redacted>

Using is_zero_ether_addr() to simplify the code.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
index 90e41db..dc9f28f0 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
@@ -1777,8 +1777,7 @@ s32 ixgbe_validate_mac_addr(u8 *mac_addr)
 	else if (IXGBE_IS_BROADCAST(mac_addr))
 		status = IXGBE_ERR_INVALID_MAC_ADDR;
 	/* Reject the zero address */
-	else if (mac_addr[0] == 0 && mac_addr[1] == 0 && mac_addr[2] == 0 &&
-	         mac_addr[3] == 0 && mac_addr[4] == 0 && mac_addr[5] == 0)
+	else if (is_zero_ether_addr(mac_addr))
 		status = IXGBE_ERR_INVALID_MAC_ADDR;
 
 	return status;

Re: [PATCH] ixgbe: using is_zero_ether_addr() to simplify the code

From: Jeff Kirsher <hidden>
Date: 2012-08-26 08:51:13

On Sun, 2012-08-26 at 08:53 +0800, Wei Yongjun wrote:
From: Wei Yongjun <redacted>

Using is_zero_ether_addr() to simplify the code.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-) 
I have added the patch to my queue of patches.  Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help