[PATCH]: net: ipv6: fix oops in inet_putpeer()

STALE5099d

2 messages, 2 authors, 2012-08-20 · open the first message on its own page

[PATCH]: net: ipv6: fix oops in inet_putpeer()

From: Patrick McHardy <hidden>
Date: 2012-08-18 15:32:34

The attached patch fixes an oops in inet_putpeer(). Please see the 
changelog entry for details.

An alternative fix would be to check whether rt6_peer_ptr() returns
NULL before invoking inet_putpeer(), but properly initializing the
peer looks cleaner to me.

Re: [PATCH]: net: ipv6: fix oops in inet_putpeer()

From: David Miller <davem@davemloft.net>
Date: 2012-08-20 09:58:23

From: Patrick McHardy <redacted>
Date: Sat, 18 Aug 2012 17:32:31 +0200 (MEST)
The attached patch fixes an oops in inet_putpeer(). Please see the
changelog entry for details.

An alternative fix would be to check whether rt6_peer_ptr() returns
NULL before invoking inet_putpeer(), but properly initializing the
peer looks cleaner to me.
This is fine for now, applied, thanks Patrick.

There was a built-in assumption that xfrm_fill_dst() would run to
completion before we'd try to release these things, because there in
xfrm6_policy.c's xfrm6_fill_dst, we'd do the rt6_transfer_peer().

But that's obviously not the case if errors happen meanwhile.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help