[PATCH] mISDN: Bugfix for layer2 fixed TEI mode

Subsystems: the rest

STALE5111d

2 messages, 2 authors, 2012-08-06 · open the first message on its own page

[PATCH] mISDN: Bugfix for layer2 fixed TEI mode

From: Karsten Keil <hidden>
Date: 2012-08-04 10:14:28

If a fixed TEI is used, the initial state of the layer 2 statmachine need to be
4 (TEI assigned). This was true only for Point to Point connections, but not
for the other fixed TEIs. It was not found before, because usually only the
TEI 0 is used as fixed TEI for PtP mode, but if you try X31 packet mode
connections with SAPI 16, TEI 1, it did fail.

Signed-off-by: Karsten Keil <redacted>
Cc: <redacted> # 3.5.x
---
 drivers/isdn/mISDN/layer2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
index 0dc8abc..949cabb 100644
--- a/drivers/isdn/mISDN/layer2.c
+++ b/drivers/isdn/mISDN/layer2.c
@@ -2222,7 +2222,7 @@ create_l2(struct mISDNchannel *ch, u_int protocol, u_long options, int tei,
 	InitWin(l2);
 	l2->l2m.fsm = &l2fsm;
 	if (test_bit(FLG_LAPB, &l2->flag) ||
-	    test_bit(FLG_PTP, &l2->flag) ||
+	    test_bit(FLG_FIXED_TEI, &l2->flag) ||
 	    test_bit(FLG_LAPD_NET, &l2->flag))
 		l2->l2m.state = ST_L2_4;
 	else
-- 
1.7.7

Re: [PATCH] mISDN: Bugfix for layer2 fixed TEI mode

From: David Miller <davem@davemloft.net>
Date: 2012-08-06 20:27:38

From: Karsten Keil <redacted>
Date: Sat,  4 Aug 2012 12:14:25 +0200
If a fixed TEI is used, the initial state of the layer 2 statmachine need to be
4 (TEI assigned). This was true only for Point to Point connections, but not
for the other fixed TEIs. It was not found before, because usually only the
TEI 0 is used as fixed TEI for PtP mode, but if you try X31 packet mode
connections with SAPI 16, TEI 1, it did fail.

Signed-off-by: Karsten Keil <redacted>
Cc: <redacted> # 3.5.x
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help