[PATCH 2/7] net/rxrpc/ar-peer.c: remove invalid reference to list iterator variable

Subsystems: networking [general], rxrpc sockets (af_rxrpc), the rest

STALE5105d

2 messages, 2 authors, 2012-07-09 · open the first message on its own page

[PATCH 2/7] net/rxrpc/ar-peer.c: remove invalid reference to list iterator variable

From: Julia Lawall <hidden>
Date: 2012-07-08 11:38:19

From: Julia Lawall <redacted>

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  This seems to be a copy-paste bug from a previous
debugging message, and so the meaningless value is just deleted.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <redacted>

---
 net/rxrpc/ar-peer.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/ar-peer.c b/net/rxrpc/ar-peer.c
index 2754f09..bebaa43 100644
--- a/net/rxrpc/ar-peer.c
+++ b/net/rxrpc/ar-peer.c
@@ -229,7 +229,7 @@ found_UDP_peer:
 	return peer;
 
 new_UDP_peer:
-	_net("Rx UDP DGRAM from NEW peer %d", peer->debug_id);
+	_net("Rx UDP DGRAM from NEW peer");
 	read_unlock_bh(&rxrpc_peer_lock);
 	_leave(" = -EBUSY [new]");
 	return ERR_PTR(-EBUSY);

Re: [PATCH 2/7] net/rxrpc/ar-peer.c: remove invalid reference to list iterator variable

From: David Miller <davem@davemloft.net>
Date: 2012-07-09 22:24:59

From: Julia Lawall <redacted>
Date: Sun,  8 Jul 2012 13:37:39 +0200
From: Julia Lawall <redacted>

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  This seems to be a copy-paste bug from a previous
debugging message, and so the meaningless value is just deleted.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help