[PATCH] seeq: use PTR_RET at init_module of driver

the driver sees wether the dev_seeq pointer is having a error that can be
read by using the PTR_ERR, and returns it at error case, other wise 0 at
success case.

the PTR_RET does the same thing, and use PTR_RET instead of redoing the
code of PTR_RET

Signed-off-by: Devendra Naga <redacted>
---
This patch is actually made by using coccinelle, and also by looking
at the PTR_RET function.

as its implementation is
static int PTR_RET(void *ptr)
{
	if (IS_ERR(ptr)
		return PTR_ERR(ptr);
	return 0;
}

by using this i removed the following code and replaced with PTR_RET....


 drivers/net/ethernet/seeq/seeq8005.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/seeq/seeq8005.c b/drivers/net/ethernet/seeq/seeq8005.c
index 698edbb..d6e50de 100644
--- a/drivers/net/ethernet/seeq/seeq8005.c
+++ b/drivers/net/ethernet/seeq/seeq8005.c

@@ -736,9 +736,7 @@ MODULE_PARM_DESC(irq, "SEEQ 8005 IRQ number");
 int __init init_module(void)
 {
 	dev_seeq = seeq8005_probe(-1);
-	if (IS_ERR(dev_seeq))
-		return PTR_ERR(dev_seeq);
-	return 0;
+	return PTR_RET(dev_seeq);
 }
 
 void __exit cleanup_module(void)

-- 
1.7.9.5

Devendra Naga [off-list ref] wrote:

the driver sees wether the dev_seeq pointer is having a error that can be
read by using the PTR_ERR, and returns it at error case, other wise 0 at
success case.

the PTR_RET does the same thing, and use PTR_RET instead of redoing the
code of PTR_RET

Signed-off-by: Devendra Naga <redacted>

Acked-by: David Howells <dhowells@redhat.com>

Sun, Jul 29, 2012 at 03:28:47PM CEST, develkernel412222@gmail.com wrote:

Reviewed-by: Jiri Pirko <jiri@resnulli.us>

From: Devendra Naga <redacted>
Date: Sun, 29 Jul 2012 19:13:47 +0545

the driver sees wether the dev_seeq pointer is having a error that can be
read by using the PTR_ERR, and returns it at error case, other wise 0 at
success case.

the PTR_RET does the same thing, and use PTR_RET instead of redoing the
code of PTR_RET

Signed-off-by: Devendra Naga <redacted>

Applied.