[PATCH] decnet: Don't set RTCF_DIRECTSRC.

Subsystems: networking [general], the rest

STALE5142d

2 messages, 2 authors, 2012-07-24 · open the first message on its own page

[PATCH] decnet: Don't set RTCF_DIRECTSRC.

From: David Miller <davem@davemloft.net>
Date: 2012-07-23 20:17:41 

It's an ipv4 defined route flag, and only ipv4 uses it.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/decnet/dn_route.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 23cc11d..85a3604 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -1424,7 +1424,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
 		/* Packet was intra-ethernet, so we know its on-link */
 		if (cb->rt_flags & DN_RT_F_IE) {
 			gateway = cb->src;
-			flags |= RTCF_DIRECTSRC;
 			goto make_route;
 		}
 
@@ -1437,7 +1436,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
 
 		/* Close eyes and pray */
 		gateway = cb->src;
-		flags |= RTCF_DIRECTSRC;
 		goto make_route;
 	default:
 		goto e_inval;
-- 
1.7.10.4

Re: [PATCH] decnet: Don't set RTCF_DIRECTSRC.

From: Steven Whitehouse <hidden>
Date: 2012-07-24 08:15:32 

Hi,

On Mon, 2012-07-23 at 13:17 -0700, David Miller wrote:
It's an ipv4 defined route flag, and only ipv4 uses it.
This flag was really just being used to tag cached (direct) routes for
debugging purposes, so looks good to me.

Acked-by: Steven Whitehouse <redacted>

Steve.
quoted hunk
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/decnet/dn_route.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 23cc11d..85a3604 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -1424,7 +1424,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
 		/* Packet was intra-ethernet, so we know its on-link */
 		if (cb->rt_flags & DN_RT_F_IE) {
 			gateway = cb->src;
-			flags |= RTCF_DIRECTSRC;
 			goto make_route;
 		}
 
@@ -1437,7 +1436,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
 
 		/* Close eyes and pray */
 		gateway = cb->src;
-		flags |= RTCF_DIRECTSRC;
 		goto make_route;
 	default:
 		goto e_inval;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help