[PATCH] bridge: fix endian

Subsystems: ethernet bridge, networking [general], the rest

STALE5173d

4 messages, 3 authors, 2012-07-11 · open the first message on its own page

[PATCH] bridge: fix endian

From: <hidden>
Date: 2012-07-10 09:56:21 

From: Li RongQing <redacted>

mld->mld_maxdelay is net endian, so we should use ntohs, not htons

CC: YOSHIFUJI Hideaki <redacted>
Signed-off-by: Li RongQing <redacted>
---
 net/bridge/br_multicast.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index b665812..2d9a066 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1160,7 +1160,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
 			goto out;
 		}
 		mld = (struct mld_msg *) icmp6_hdr(skb);
-		max_delay = msecs_to_jiffies(htons(mld->mld_maxdelay));
+		max_delay = msecs_to_jiffies(ntohs(mld->mld_maxdelay));
 		if (max_delay)
 			group = &mld->mld_mca;
 	} else if (skb->len >= sizeof(*mld2q)) {
-- 
1.7.1

Re: [PATCH] bridge: fix endian

From: devendra.aaru <hidden>
Date: 2012-07-10 10:04:39 

As you are doing the same change to the drivers in drivers/net/*** i
think a patchset would be better.

but that's just upto you. ;-)

Thanks,

On Tue, Jul 10, 2012 at 3:26 PM,  [off-list ref] wrote:
quoted hunk
From: Li RongQing <redacted>

mld->mld_maxdelay is net endian, so we should use ntohs, not htons

CC: YOSHIFUJI Hideaki <redacted>
Signed-off-by: Li RongQing <redacted>
---
 net/bridge/br_multicast.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index b665812..2d9a066 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1160,7 +1160,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
                        goto out;
                }
                mld = (struct mld_msg *) icmp6_hdr(skb);
-               max_delay = msecs_to_jiffies(htons(mld->mld_maxdelay));
+               max_delay = msecs_to_jiffies(ntohs(mld->mld_maxdelay));
                if (max_delay)
                        group = &mld->mld_mca;
        } else if (skb->len >= sizeof(*mld2q)) {
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bridge: fix endian

From: RongQing Li <hidden>
Date: 2012-07-10 14:00:46 

2012/7/10, devendra.aaru [off-list ref]:
As you are doing the same change to the drivers in drivers/net/*** i
think a patchset would be better.

but that's just upto you. ;-)

Thanks,
If I can find others afterward, I will change them on a patchset.
Thanks

-Roy

Re: [PATCH] bridge: fix endian

From: David Miller <davem@davemloft.net>
Date: 2012-07-11 08:32:03 

From: roy.qing.li@gmail.com
Date: Tue, 10 Jul 2012 17:56:12 +0800

From: Li RongQing <redacted>

mld->mld_maxdelay is net endian, so we should use ntohs, not htons

CC: YOSHIFUJI Hideaki <redacted>
Signed-off-by: Li RongQing <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help