[PATCH] r6040: remove duplicate call to the pci_set_drvdata

Subsystems: networking drivers, rdc r6040 fast ethernet driver, the rest

STALE5185d

2 messages, 2 authors, 2012-07-07 · open the first message on its own page

[PATCH] r6040: remove duplicate call to the pci_set_drvdata

From: Devendra Naga <hidden>
Date: 2012-07-07 06:07:44

pci_set_drvdata is called twice at the remove path of driver,
call it once.

Signed-off-by: Devendra Naga <redacted>
---
 drivers/net/ethernet/rdc/r6040.c |    1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index d1827e8..9acc026 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -1256,7 +1256,6 @@ static void __devexit r6040_remove_one(struct pci_dev *pdev)
 	kfree(lp->mii_bus->irq);
 	mdiobus_free(lp->mii_bus);
 	netif_napi_del(&lp->napi);
-	pci_set_drvdata(pdev, NULL);
 	pci_iounmap(pdev, lp->base);
 	pci_release_regions(pdev);
 	free_netdev(dev);
-- 
1.7.9.5

Re: [PATCH] r6040: remove duplicate call to the pci_set_drvdata

From: David Miller <davem@davemloft.net>
Date: 2012-07-07 23:16:25

From: Devendra Naga <redacted>
Date: Sat,  7 Jul 2012 11:37:35 +0530
pci_set_drvdata is called twice at the remove path of driver,
call it once.

Signed-off-by: Devendra Naga <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help