[PATCH] mac80211: fix build warning

Subsystems: mac80211, the rest

STALE5214d

3 messages, 2 authors, 2012-06-25 · open the first message on its own page

[PATCH] mac80211: fix build warning

From: Alexandre Pereira da Silva <hidden>
Date: 2012-06-25 15:19:16

Fix:
net/mac80211/mlme.c: In function 'ieee80211_prep_connection':
net/mac80211/mlme.c:3035:19: warning: 'sta' may be used uninitialized in
this function

Initialize sta to NULL

Signed-off-by: Alexandre Pereira da Silva <redacted>
---
 net/mac80211/mlme.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 91d84cc..cfe6b43 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -3032,7 +3032,7 @@ static int ieee80211_prep_connection(struct ieee80211_sub_if_data *sdata,
 	struct ieee80211_local *local = sdata->local;
 	struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
 	struct ieee80211_bss *bss = (void *)cbss->priv;
-	struct sta_info *sta;
+	struct sta_info *sta = NULL;
 	bool have_sta = false;
 	int err;
 	int ht_cfreq;
-- 
1.7.10

Re: [PATCH] mac80211: fix build warning

From: Mohammed Shafi <hidden>
Date: 2012-06-25 15:31:31

Hi,

On Mon, Jun 25, 2012 at 8:49 PM, Alexandre Pereira da Silva
[off-list ref] wrote:
Fix:
net/mac80211/mlme.c: In function 'ieee80211_prep_connection':
net/mac80211/mlme.c:3035:19: warning: 'sta' may be used uninitialized in
this function

Initialize sta to NULL
i think already fixed by and there in wireless-testing
http://www.spinics.net/lists/linux-wireless/msg92385.html
quoted hunk
Signed-off-by: Alexandre Pereira da Silva <redacted>
---
 net/mac80211/mlme.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 91d84cc..cfe6b43 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -3032,7 +3032,7 @@ static int ieee80211_prep_connection(struct ieee80211_sub_if_data *sdata,
       struct ieee80211_local *local = sdata->local;
       struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
       struct ieee80211_bss *bss = (void *)cbss->priv;
-       struct sta_info *sta;
+       struct sta_info *sta = NULL;
       bool have_sta = false;
       int err;
       int ht_cfreq;
--
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
thanks,
shafi

Re: [PATCH] mac80211: fix build warning

From: Alexandre Pereira da Silva <hidden>
Date: 2012-06-25 15:33:54

On Mon, Jun 25, 2012 at 12:31 PM, Mohammed Shafi
[off-list ref] wrote:
Hi,

On Mon, Jun 25, 2012 at 8:49 PM, Alexandre Pereira da Silva
[off-list ref] wrote:
quoted
Fix:
net/mac80211/mlme.c: In function 'ieee80211_prep_connection':
net/mac80211/mlme.c:3035:19: warning: 'sta' may be used uninitialized in
this function

Initialize sta to NULL
i think already fixed by and there in wireless-testing
http://www.spinics.net/lists/linux-wireless/msg92385.html
Ok, thanks for pointing that out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help