4 messages, 3 authors, 2012-06-15 · open the first message on its own page
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2012-06-15 07:36:59
On Thu, 2012-06-14 at 22:53 -0700, Joe Perches wrote:
Update logging style
So ... since we make everybody else explain *why* they make a change, I think you should too. I don't see a reason for this random patching of perfectly good code. johannes
From: Joe Perches <joe@perches.com>
Date: 2012-06-15 10:48:42
On Fri, 2012-06-15 at 09:36 +0200, Johannes Berg wrote:
On Thu, 2012-06-14 at 22:53 -0700, Joe Perches wrote:quoted
Update logging styleSo ... since we make everybody else explain *why* they make a change, I think you should too.
To improve logging style consistency.
To reduce logging defects.
To standardize logging prefixes.
To tee up conversions of:
pr_<level>("%s: ...", ([truct netdevice *]foo)->name, ...)
to
netdev_<level>(foo, "...", ...)
From: "Ted Ts'o" <tytso@mit.edu>
Date: 2012-06-15 23:29:53
On Fri, Jun 15, 2012 at 03:48:39AM -0700, Joe Perches wrote:
To tee up conversions of:
pr_<level>("%s: ...", ([truct netdevice *]foo)->name, ...)
to
netdev_<level>(foo, "...", ...) If the goal is to do the latter, why introduce needless patch churn now just to get to pr_<level>? Having a standardized netdev_<label>() adds real benefit that can be weighed against the cost of code churn. Why not just wait until the netdev_<level> infrastructure can be introduced? It will save effort on everybody's part. - Ted
From: Joe Perches <joe@perches.com>
Date: 2012-06-15 23:37:20
On Fri, 2012-06-15 at 18:50 -0400, Ted Ts'o wrote:
On Fri, Jun 15, 2012 at 03:48:39AM -0700, Joe Perches wrote:quoted
To tee up conversions of: pr_<level>("%s: ...", ([truct netdevice *]foo)->name, ...) to netdev_<level>(foo, "...", ...)If the goal is to do the latter, why introduce needless patch churn now just to get to pr_<level>? Having a standardized netdev_<label>() adds real benefit that can be weighed against the cost of code churn. Why not just wait until the netdev_<level> infrastructure can be introduced? It will save effort on everybody's part.
Not really. This standardizes prefixes as is. The newlines and such will still occur. The git blame noise etc too. The standardization via spatch will be significantly easier this way. It's also a far easier pattern to verify. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html