Re: [Xen-devel] [PATCH 1/1] xen/netback: only non-freed SKB is queued into tx_queue
From: Ian Campbell <hidden>
Date: 2012-06-29 07:23:11
Also in:
xen-devel
From: Ian Campbell <hidden>
Date: 2012-06-29 07:23:11
Also in:
xen-devel
On Fri, 2012-06-29 at 00:55 +0100, David Miller wrote:
From: annie.li@oracle.com Date: Wed, 27 Jun 2012 18:46:58 +0800quoted
From: Annie Li <redacted> After SKB is queued into tx_queue, it will be freed if request_gop is NULL. However, no dequeue action is called in this situation, it is likely that tx_queue constains freed SKB. This patch should fix this issue, and it is based on 3.5.0-rc4+. This issue is found through code inspection, no bug is seen with it currently. I run netperf test for several hours, and no network regression was found. Signed-off-by: Annie Li <redacted>I lack the expertiece necessary to properly review this, so I really need a Xen expert to look this over.
Sorry, I put it to one side waiting for the repost to netdev and then forgot about it... Yes, this change looks good to me: Acked-by: Ian Campbell <redacted>