[PATCH 1/1]net:ethernet:fixed a coding style issue relating space.

Subsystems: networking [general], the rest

STALE5201d

2 messages, 2 authors, 2012-05-18 · open the first message on its own page

[PATCH 1/1]net:ethernet:fixed a coding style issue relating space.

From: Jeffrin Jose <hidden>
Date: 2012-05-18 21:48:58

Fixed a coding style issue relating to  space found
by checkpatch.pl tool in net/ethernet/eth.c

Signed-off-by: Jeffrin Jose <redacted>
---
 net/ethernet/eth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index 36e5880..c847aa6 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
 	 *      seems to set IFF_PROMISC.
 	 */
 
-	else if (1 /*dev->flags&IFF_PROMISC */ ) {
+	else if (1 /*dev->flags&IFF_PROMISC */) {
 		if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
 						      dev->dev_addr)))
 			skb->pkt_type = PACKET_OTHERHOST;
-- 
1.7.10

Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.

From: Stephen Hemminger <hidden>
Date: 2012-05-18 21:56:21

On Sat, 19 May 2012 03:15:37 +0530
Jeffrin Jose [off-list ref] wrote:
quoted hunk
Fixed a coding style issue relating to  space found
by checkpatch.pl tool in net/ethernet/eth.c

Signed-off-by: Jeffrin Jose <redacted>
---
 net/ethernet/eth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index 36e5880..c847aa6 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
 	 *      seems to set IFF_PROMISC.
 	 */
 
-	else if (1 /*dev->flags&IFF_PROMISC */ ) {
+	else if (1 /*dev->flags&IFF_PROMISC */) {
 		if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
 						      dev->dev_addr)))
 			skb->pkt_type = PACKET_OTHERHOST;
Rather than put lips on a pig, why not remove the bogus if?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help