[PATCH] ptp_pch: Add missing #include <linux/slab.h>

Subsystems: networking drivers, ptp hardware clock support, the rest

STALE5203d

3 messages, 2 authors, 2012-05-16 · open the first message on its own page

[PATCH] ptp_pch: Add missing #include <linux/slab.h>

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2012-05-16 08:43:40

drivers/ptp/ptp_pch.c: In function 'pch_eth_enable_set':
drivers/ptp/ptp_pch.c:152:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
drivers/ptp/ptp_pch.c:153:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Not even compile-tested, as it fails on parisc/xtensa only.
http://kisskb.ellerman.id.au/kisskb/buildresult/6312813/
http://kisskb.ellerman.id.au/kisskb/buildresult/6313050/

 drivers/ptp/ptp_pch.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c
index 375eb04..6fff680 100644
--- a/drivers/ptp/ptp_pch.c
+++ b/drivers/ptp/ptp_pch.c
@@ -30,6 +30,7 @@
 #include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/ptp_clock_kernel.h>
+#include <linux/slab.h>
 
 #define STATION_ADDR_LEN	20
 #define PCI_DEVICE_ID_PCH_1588	0x8819
-- 
1.7.0.4

Re: [PATCH] ptp_pch: Add missing #include <linux/slab.h>

From: Ben Hutchings <hidden>
Date: 2012-05-16 11:41:03

On Wed, 2012-05-16 at 10:43 +0200, Geert Uytterhoeven wrote:
drivers/ptp/ptp_pch.c: In function 'pch_eth_enable_set':
drivers/ptp/ptp_pch.c:152:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
drivers/ptp/ptp_pch.c:153:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]
<linux/io.h> might be more useful.

Ben.
quoted hunk
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Not even compile-tested, as it fails on parisc/xtensa only.
http://kisskb.ellerman.id.au/kisskb/buildresult/6312813/
http://kisskb.ellerman.id.au/kisskb/buildresult/6313050/

 drivers/ptp/ptp_pch.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c
index 375eb04..6fff680 100644
--- a/drivers/ptp/ptp_pch.c
+++ b/drivers/ptp/ptp_pch.c
@@ -30,6 +30,7 @@
 #include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/ptp_clock_kernel.h>
+#include <linux/slab.h>
 
 #define STATION_ADDR_LEN	20
 #define PCI_DEVICE_ID_PCH_1588	0x8819
-- 
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.

Re: [PATCH] ptp_pch: Add missing #include <linux/slab.h>

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2012-05-16 11:52:28

On Wed, May 16, 2012 at 1:40 PM, Ben Hutchings [off-list ref] wrote:
On Wed, 2012-05-16 at 10:43 +0200, Geert Uytterhoeven wrote:
quoted
drivers/ptp/ptp_pch.c: In function 'pch_eth_enable_set':
drivers/ptp/ptp_pch.c:152:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
drivers/ptp/ptp_pch.c:153:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]
<linux/io.h> might be more useful.
Bummer, I copied the wrong error from the log ;-(
I resent the correct version.

But indeed, <linux/io.h> is also missing. But that error was not a regression
in 3.4-rc7 ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help