[PATCH] net/bluetooth/bnep/core.c: use constant for ethertype

Subsystems: bluetooth subsystem, the rest

STALE5214d

2 messages, 2 authors, 2012-05-09 · open the first message on its own page

[PATCH] net/bluetooth/bnep/core.c: use constant for ethertype

From: Eldad Zack <hidden>
Date: 2012-05-07 22:09:52

The dot1q ethertype number (0x8100) is embedded in the code, although
it is already defined in included headers.

Signed-off-by: Eldad Zack <redacted>
---
 net/bluetooth/bnep/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
index a779ec7..4fab436 100644
--- a/net/bluetooth/bnep/core.c
+++ b/net/bluetooth/bnep/core.c
@@ -340,7 +340,7 @@ static inline int bnep_rx_frame(struct bnep_session *s, struct sk_buff *skb)
 	}
 
 	/* Strip 802.1p header */
-	if (ntohs(s->eh.h_proto) == 0x8100) {
+	if (ntohs(s->eh.h_proto) == ETH_P_8021Q) {
 		if (!skb_pull(skb, 4))
 			goto badframe;
 		s->eh.h_proto = get_unaligned((__be16 *) (skb->data - 2));
-- 
1.7.10

Re: [PATCH] net/bluetooth/bnep/core.c: use constant for ethertype

From: Gustavo Padovan <hidden>
Date: 2012-05-09 04:09:12

Hi Eldad,

* Eldad Zack [off-list ref] [2012-05-08 00:09:35 +0200]:
The dot1q ethertype number (0x8100) is embedded in the code, although
it is already defined in included headers.

Signed-off-by: Eldad Zack <redacted>
---
 net/bluetooth/bnep/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Patch has been applied to bluetooth-next. Thanks.

	Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help