Re: [REGRESSION][PATCH] Fix an old sky2 WOL regression

Dear Knut,

I am sorry it took a while to try it due to other 
commitments, however I can now confirm the patch works on my ASUS P5LD2 
motherboard.

Many thanks
Nicola

On 2012-03-21 12:40, Knut Petersen 
wrote:

Sky2 Wake on LAN is broken since February 2010 on a number of 

systems.

Yes. More than two years.

We know about the problem and 

the cause since October 2010

(Bugzilla bug #19492). It´s commit 

87b09f1f25cd1e01d7c50bf423c7fe33027d7511.

Stephen, David: You 

signed off that commit.

Andrew: You called it a regression in 

October 2010.

It has been proposed to revert the commit that caused 

the problem.

Nothing happened.

I proposed to re-establish the old 

code for dmi_match()ed systems.

Without success.

Now it is 

proposed to re-establish the old code as a configuration option.

If 

nothing happens again I will propose a module parameter ;-)

Stephen, I don´t want to be a pain in the neck, and it is not my 
intention

to offend you by my "attitude". But I simply cannot 

understand why this

know regression is not fixed. The bit we talk 

about is documented,

and in fact it was set for a number of kernel 

versions unconditionally.

Nobody complained about ruined hardware or 

minor problems.

The systems affected are old enough that no 

manufacturer cares about

them, but they are still quite usable for a 

lot of jobs (kernel 3.3 compile

time here is below 15 minutes).

If there is a problem in the kernel and if we do know an easy solution,

that solution should be commited to the kernel, no matter what is 

written

in some random documentation, no matter if we could blame 

some

BIOS authors. That´s the way Linux works - at least I thought 

so.

cu,
Knut