Re: [PATCH net-next] bnx2x: remove some bloat
From: Eilon Greenstein <hidden>
Date: 2012-05-01 06:58:27
On Sat, 2012-04-28 at 09:39 +0200, Eric Dumazet wrote:
From: Eric Dumazet <edumazet@google.com> Before doing skb->head_frag work on bnx2x driver, I found too much stuff was inlined in bnx2x/bnx2x_cmn.h for no good reason and made my work not very easy. Move some big functions out of this include file to the respective .c file. A lot of inline keywords are not needed at all in this huge driver. text data bss dec hex filename 490083 1270 56 491409 77f91 bnx2x/bnx2x.ko.before 484206 1270 56 485532 7689c bnx2x/bnx2x.ko Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Eilon Greenstein <redacted> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Maciej Żenczykowski <redacted> Cc: Neal Cardwell <ncardwell@google.com> Cc: Tom Herbert <redacted> Cc: Jeff Kirsher <redacted> Cc: Ben Hutchings <redacted> Cc: Matt Carlson <redacted> Cc: Michael Chan <mchan@broadcom.com>
Acked-by: Eilon Greenstein <redacted> Thanks Eric - it makes sense.