[PATCH] net: qmi_wwan: fix build error due to cdc-wdm dependecy

Subsystems: networking drivers, the rest, usb networking drivers

STALE5285d

3 messages, 3 authors, 2012-03-19 · open the first message on its own page

[PATCH] net: qmi_wwan: fix build error due to cdc-wdm dependecy

From: Bjørn Mork <bjorn@mork.no>
Date: 2012-03-19 17:49:17

Fixes:

drivers/built-in.o: In function `qmi_wwan_bind_shared':
qmi_wwan.c:(.text+0x25b686): undefined reference to `usb_cdc_wdm_register'
make[1]: *** [.tmp_vmlinux1] Error 1

Reported-by: Randy Dunlap <redacted>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
Thanks for noticing.

This should have been in commit c3ecb08a
 net: qmi_wwan: support devices having a shared QMI/wwan interface


Bjørn


 drivers/net/usb/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 4bad899..833e32f 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -401,6 +401,7 @@ config USB_NET_KALMIA
 config USB_NET_QMI_WWAN
 	tristate "QMI WWAN driver for Qualcomm MSM based 3G and LTE modems"
 	depends on USB_USBNET
+	select USB_WDM
 	help
 	  Support WWAN LTE/3G devices based on Qualcomm Mobile Data Modem
 	  (MDM) chipsets.  Examples of such devices are
-- 
1.7.9.1

Re: [PATCH] net: qmi_wwan: fix build error due to cdc-wdm dependecy

From: Randy Dunlap <hidden>
Date: 2012-03-19 20:16:58

On 03/19/2012 10:48 AM, Bjørn Mork wrote:
Fixes:

drivers/built-in.o: In function `qmi_wwan_bind_shared':
qmi_wwan.c:(.text+0x25b686): undefined reference to `usb_cdc_wdm_register'
make[1]: *** [.tmp_vmlinux1] Error 1

Reported-by: Randy Dunlap <redacted>
Signed-off-by: Bjørn Mork <bjorn@mork.no>

Acked-by: Randy Dunlap <redacted>

Thanks.

quoted hunk
---
Thanks for noticing.

This should have been in commit c3ecb08a
 net: qmi_wwan: support devices having a shared QMI/wwan interface


Bjørn


 drivers/net/usb/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 4bad899..833e32f 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -401,6 +401,7 @@ config USB_NET_KALMIA
 config USB_NET_QMI_WWAN
 	tristate "QMI WWAN driver for Qualcomm MSM based 3G and LTE modems"
 	depends on USB_USBNET
+	select USB_WDM
 	help
 	  Support WWAN LTE/3G devices based on Qualcomm Mobile Data Modem
 	  (MDM) chipsets.  Examples of such devices are


-- 
~Randy

Re: [PATCH] net: qmi_wwan: fix build error due to cdc-wdm dependecy

From: David Miller <davem@davemloft.net>
Date: 2012-03-19 22:20:47

From: Randy Dunlap <redacted>
Date: Mon, 19 Mar 2012 13:16:55 -0700
On 03/19/2012 10:48 AM, Bjørn Mork wrote:
quoted
Fixes:

drivers/built-in.o: In function `qmi_wwan_bind_shared':
qmi_wwan.c:(.text+0x25b686): undefined reference to `usb_cdc_wdm_register'
make[1]: *** [.tmp_vmlinux1] Error 1

Reported-by: Randy Dunlap <redacted>
Signed-off-by: Bjørn Mork <bjorn@mork.no>

Acked-by: Randy Dunlap <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help