[PATCH 2/3] qla3xxx: ethernet: Silence static checker warning.

Subsystems: networking drivers, qlogic qla3xxx network driver, the rest

STALE5300d

2 messages, 2 authors, 2012-03-05 · open the first message on its own page

[PATCH 2/3] qla3xxx: ethernet: Silence static checker warning.

From: santosh nayak <hidden>
Date: 2012-03-02 15:10:34

From: Santosh Nayak <redacted>

Silence the following warning:
"warn: returning -1 instead of -ENOMEM is sloppy".

Signed-off-by: Santosh Nayak <redacted>
---
 drivers/net/ethernet/qlogic/qla3xxx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 8da3e41..df09b1c 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -2836,7 +2836,7 @@ static int ql_create_send_free_list(struct ql3_adapter *qdev)
 		req_q_curr++;
 		tx_cb->oal = kmalloc(512, GFP_KERNEL);
 		if (tx_cb->oal == NULL)
-			return -1;
+			return -ENOMEM;
 	}
 	return 0;
 }
-- 
1.7.4.4

Re: [PATCH 2/3] qla3xxx: ethernet: Silence static checker warning.

From: David Miller <davem@davemloft.net>
Date: 2012-03-05 21:54:05

From: santosh nayak <redacted>
Date: Fri,  2 Mar 2012 20:39:39 +0530
From: Santosh Nayak <redacted>

Silence the following warning:
"warn: returning -1 instead of -ENOMEM is sloppy".

Signed-off-by: Santosh Nayak <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help