[PATCH] davinci_emac: fixed setting MAC at init time

Subsystems: networking drivers, the rest, ti ethernet switch driver (cpsw)

STALE5326d

2 messages, 2 authors, 2012-03-01 · open the first message on its own page

[PATCH] davinci_emac: fixed setting MAC at init time

From: Bas van den Berg <hidden>
Date: 2012-03-01 08:42:50

Without this patch, the MAC number will show up as zero's until the interface
is brought up for the first time. (eg. with ifconfig -a)

Signed-off-by: Bas van den Berg <redacted>
---
 drivers/net/ethernet/ti/davinci_emac.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index 4b2f545..11b169a 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -1904,6 +1904,7 @@ static int __devinit davinci_emac_probe(struct platform_device *pdev)
 		dev_warn(&pdev->dev, "using random MAC addr: %pM\n",
 							priv->mac_addr);
 	}
+	memcpy(ndev->dev_addr, priv->mac_addr, ndev->addr_len);
 
 	ndev->netdev_ops = &emac_netdev_ops;
 	SET_ETHTOOL_OPS(ndev, &ethtool_ops);
-- 
1.7.0.4

Re: [PATCH] davinci_emac: fixed setting MAC at init time

From: David Miller <davem@davemloft.net>
Date: 2012-03-01 21:32:12

From: Bas van den Berg <redacted>
Date: Thu, 1 Mar 2012 09:42:42 +0100
Without this patch, the MAC number will show up as zero's until the interface
is brought up for the first time. (eg. with ifconfig -a)

Signed-off-by: Bas van den Berg <redacted>
Well then the copy (which is also unnecessarily by hand using a loop
instead of a memcpy call) in emac_dev_open() is redundant and should
be removed when you make this change.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help