[PATCH 1/3] Fix non TBI PHY access; a bad merge undid bug fix in a previous commit.

Subsystems: networking drivers, the rest

STALE5282d

2 messages, 2 authors, 2012-04-01 · open the first message on its own page

[PATCH 1/3] Fix non TBI PHY access; a bad merge undid bug fix in a previous commit.

From: Kenth Eriksson <hidden>
Date: 2012-03-28 08:14:38

Commit b26e478f undid bug fix in commit c3e072f8, with the result that non TBI (e.g. MDIO) PHYs cannot be accessed.

Signed-off-by: Kenth Eriksson <redacted>
---
 drivers/net/ethernet/freescale/fsl_pq_mdio.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index 9eb8159..f7f0bf5 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -356,13 +356,13 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev)
 
 		if (prop)
 			tbiaddr = *prop;
-	}
 
-	if (tbiaddr == -1) {
-		err = -EBUSY;
-		goto err_free_irqs;
-	} else {
-		out_be32(tbipa, tbiaddr);
+		if (tbiaddr == -1) {
+			err = -EBUSY;
+			goto err_free_irqs;
+		} else {
+			out_be32(tbipa, tbiaddr);
+		}
 	}
 
 	err = of_mdiobus_register(new_bus, np);
-- 
1.7.3.4

Re: [PATCH 1/3] Fix non TBI PHY access; a bad merge undid bug fix in a previous commit.

From: David Miller <davem@davemloft.net>
Date: 2012-04-01 20:16:38

From: Kenth Eriksson <redacted>
Date: Wed, 28 Mar 2012 10:05:54 +0200
Commit b26e478f undid bug fix in commit c3e072f8, with the result
that non TBI (e.g. MDIO) PHYs cannot be accessed.

Signed-off-by: Kenth Eriksson <redacted>
Applied and queued up for -stable.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help