On Mon, 2012-03-19 at 18:06 -0400, David Miller wrote:

From: Mugunthan V N <redacted>
Date: Mon, 19 Mar 2012 11:47:52 +0530

quoted

The following series contains driver implementation for TI Common Platform
ethernet SWitch (CPSW) driver.

CPSW is found in following SoC.
* AM335X - http://www.ti.com/litv/pdf/spruh73c
* DM814X - http://www.ti.com/litv/pdf/sprugz8

CPSW:
The three port switch gigabit ethernet subsystem provides ethernet packet
communication and can be configured as an ethernet switch.  It
supports 10/100/1000 Mbps. It provides the gigabit media independent
interface (G/MII), reduced gigabit media independent interface (RGMII),
reduced media independent interface (RMII), the management data input
output (MDIO) for physical layer device (PHY) management.

All applied.

It appears this driver doesnt have a ndo_change_mtu method, so I suspect
some bad things could happen.

I wonder if we should WARN is netdev_ops->ndo_change_mtu is NULL

For an ethernet driver, using eth_change_mtu seems the right thing.