Improve rds_sendmsg printk

- Given this can be called by any user, prevent them from flooding
  the logs by using printk_ratelimited
- Also add a rds: prefix, so it's clear where the message is coming from.

Signed-off-by: Dave Jones <redacted>

--- linux/net/rds/send.c	2011-11-07 12:00:32.000000000 -0500
+++ linux/net/rds/send.c	2012-03-19 18:36:21.804991923 -0400

@@ -935,7 +935,7 @@ int rds_sendmsg(struct kiocb *iocb, stru
 	/* Mirror Linux UDP mirror of BSD error message compatibility */
 	/* XXX: Perhaps MSG_MORE someday */
 	if (msg->msg_flags & ~(MSG_DONTWAIT | MSG_CMSG_COMPAT)) {
-		printk(KERN_INFO "msg_flags 0x%08X\n", msg->msg_flags);
+		printk_ratelimited(KERN_INFO "rds: msg_flags 0x%08X\n", msg->msg_flags);
 		ret = -EOPNOTSUPP;
 		goto out;
 	}

From: Dave Jones <redacted>
Date: Mon, 19 Mar 2012 18:40:09 -0400

- Given this can be called by any user, prevent them from flooding
  the logs by using printk_ratelimited
- Also add a rds: prefix, so it's clear where the message is coming from.

Signed-off-by: Dave Jones <redacted>

I think it should be removed entirely, no socket layer outputs
a message for this error and neither should rds.

no socket layer outputs a message for this error and neither should rds.

Signed-off-by: Dave Jones <redacted>

--- linux/net/rds/send.c	2011-11-07 12:00:32.000000000 -0500
+++ linux/net/rds/send.c	2012-03-19 18:59:55.905890597 -0400

@@ -935,7 +935,6 @@ int rds_sendmsg(struct kiocb *iocb, stru
 	/* Mirror Linux UDP mirror of BSD error message compatibility */
 	/* XXX: Perhaps MSG_MORE someday */
 	if (msg->msg_flags & ~(MSG_DONTWAIT | MSG_CMSG_COMPAT)) {
-		printk(KERN_INFO "msg_flags 0x%08X\n", msg->msg_flags);
 		ret = -EOPNOTSUPP;
 		goto out;
 	}

On Mon, 2012-03-19 at 18:40 -0400, Dave Jones wrote:

It might be better to use net_ratelimit
for all the rds printk_ratelimited calls.

That's a bit more standardized across net/

On 3/19/2012 5:43 PM, David Miller wrote:

From: Dave Jones<redacted>
Date: Mon, 19 Mar 2012 18:40:09 -0400

quoted

- Given this can be called by any user, prevent them from flooding
   the logs by using printk_ratelimited
- Also add a rds: prefix, so it's clear where the message is coming from.

Signed-off-by: Dave Jones<redacted>

I think it should be removed entirely, no socket layer outputs
a message for this error and neither should rds.

Agree, the message could be removed entirely.

Venkat

From: Dave Jones <redacted>
Date: Mon, 19 Mar 2012 19:01:07 -0400

no socket layer outputs a message for this error and neither should rds.

Signed-off-by: Dave Jones <redacted>

Applied and queued up for -stable, thanks.